Re: [PATCH 1/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver

From: Bryan O'Donoghue
Date: Tue Nov 04 2014 - 05:55:33 EST


On 04/11/14 00:51, Chen, Alvin wrote:
-----Original Message-----
From: Chen, Alvin
Sent: Tuesday, November 4, 2014 8:46 AM
To: 'Bryan O'Donoghue'; Tan, Raymond; Lee Jones; Samuel Ortiz
Cc: linux-kernel@xxxxxxxxxxxxxxx; Shevchenko, Andriy
Subject: RE: [PATCH 1/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000
I2C-GPIO MFD Driver


On 03/11/14 07:39, Raymond Tan wrote:
+ pdata->properties->irq = pdev->irq;
+ pdata->properties->irq_shared = true;

OK I see it.

Thanks.

My question is. How extensively have edge triggered interrupts been
tested on the GPIO block ?

The BSP reference code is quite explicit about not missing edge interrupts.

Have you tested GPIO input in edge mode ?
We indeed test edge mode. Now all are moved to gpio-dwapb module which
has been accepted by maintainer.

OK then good enough for me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/