Re: [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it

[Al Viro]

On Tue, Nov 04, 2014 at 04:37:52PM +0100, Jan Kara wrote:
> On Tue 04-11-14 14:46:11, Al Viro wrote:
> > On Wed, Oct 22, 2014 at 10:14:11PM +0200, Jan Kara wrote:
> > > Currently i_cdev reference to a character device isn't accounted in the
> > > reference count of the character device. This then requires us to track
> > > all references through a list of all inodes referencing a character
> > > device which is somewhat clumsy and requires list_head in each inode in
> > > the system.
> > > 
> > > So make i_cdev a reference like any other.
> > 
> > So no rmmod for you until an inode of character device node you had
> > closed a while ago finally gets evicted from icache?  Or am I misreading
> > you?
>   Yes, this is a consequence of the change. I should have noted in the
> changelog I guess.

That consequence looks broken, IMO.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/