Re: [PATCH v1 09/11] backports: use Kconfig for backport version information
From: Luis R. Rodriguez
Date: Tue Nov 04 2014 - 18:33:44 EST
On Tue, Nov 04, 2014 at 11:13:05AM +0100, Johannes Berg wrote:
> On Tue, 2014-11-04 at 00:43 -0800, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> >
> > Instead of relying on Makefile hacks just use Kconfig for
> > defining the variables needed. We can do this since these
> > variables are all known at packaging time. The exception
> > is BACKPORTS_GIT_TRACKED, but for that we can define a
> > kconfig variable which only if set will we rely on the
> > environment for picking it up and later exporting it through
> > Kconfig. Since Kconfig doesn't keep config variables defined
> > with option env we use a secondary config entry for that.
>
> I'd prefer you didn't do this. When we track the backports in a git tree
> this will mean constant changes to these files, where currently the
> changes are constrained to just the "versions" file.
I wanted to at least unify the C code defines for the shared
versioning information, I've come up with a way that
minimizes the changes to the existing packaging stuff,
will send in my respin. Hopefully that's OK.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/