Re: Subject: [PATCH] kobject: fix the race between kobject_del and get_device_parent

[Tejun Heo]

Hello,

On Wed, Nov 05, 2014 at 11:27:39AM +0800, Yijing Wang wrote:
> Keep the parent directory looks good to me,  we could only add kobject_get(&parent)
> after the parent dir be created.
> 
> ....
> 		/* or create a new class-directory at the parent device */
> 		k = class_dir_create_and_add(dev->class, parent_kobj);
> 		/* do not emit an uevent for this simple "glue" directory */
> 		kobject_get(k);  <--------add parent ref count for first child device.

The created directory would already have the base ref.  I don't think
you need the above.  Just never put the parent once created.

Greg, how does this sound to you?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/