Re: [PATCH v1 10/11] backports: prefix c-file / h-file auto backport with BPAUTO
From: Luis R. Rodriguez
Date: Wed Nov 05 2014 - 03:20:35 EST
On Wed, Nov 05, 2014 at 09:12:03AM +0100, Johannes Berg wrote:
> On Wed, 2014-11-05 at 09:02 +0100, Luis R. Rodriguez wrote:
>
> > > But the *code* changes
> > > you're making here that check whether bp_prefix is being duplicated
> > > aren't necessary for that, and are in fact confusing and dangerous.
> >
> > Understood, thanks for the review, hopefully this is addressed with the
> > latest series.
>
> Actually, maybe you wanted these changes because you didn't want to end
> up with CONFIG_BACKPORT_BPAUTO_ for integration? I think that's a small
> price to pay though for code complexity trade-off, IMHO you should
> accept CONFIG_BACKPORT_BPAUTO_ and remove the code changes.
Quite the contrary, I did this to get CONFIG_BACKPORT_BPAUTO_ and not
CONFIG_BACKPORT_BACKPORT_. So right now I do get CONFIG_BACKPORT_BPAUTO_
for integration (with the v2 patch series).
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/