Re: [PATCH] kvm: x86: vmx: avoid returning bool to distinguish success from error

[Paolo Bonzini]

On 05/11/2014 02:43, Chen, Tiejun wrote:
>>
>> +        default:
>> +            WARN_ON(1);
>> +            continue;
> 
> 'continue' versus 'break'?

Yes, it avoids falling through to "vmcs12_write_any(&vmx->vcpu, field,
field_value)".

> Looks we're missing another place, 

Right, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/