Re: [PATCH] acct: eliminate compile warning

[Al Viro]

On Tue, Aug 26, 2014 at 04:25:01PM -0700, Andrew Morton wrote:

> We could actually do
> 
> 	if (ACCT_VERSION == 3)
> 		...
> 
> in lots of places in acct.c.  The code would be less ugly and
> compilation coverage testing would improve.

... too much.  Finally got around to trying that; the problem is that
you can't do that in structure declarations.  acct_t is either struct
acct, or struct acct_v3, and while we could split fill_ac() into
v3 and v1/v2 versions, it still doesn't sort everything out.  So it
looks like that idea is no-go ;-/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/