Re: [PATCH v5 7/7] tpm: create TPM 2.0 devices using own device class

[Jason Gunthorpe]

On Wed, Nov 05, 2014 at 09:40:29AM +0200, Jarkko Sakkinen wrote:

> > I mean, if we have a patch that does:
> > 
> > struct tpm_chip {
> >    struct device cdev;  // the class device
> >    struct device *pdev; // the 'platform' device chip is bound too
> > 
> >    struct device *dev = pdev; // Temporary Compatability
> > [+ device_register/etc/etc]
> > 
> > Then both cdev and pdev should always be valid. We should not have cdev
> > be valid for TPM2 and invalid for TPM1, that is just a big mess.

> As a first patch I'll do a patch that does dev -> pdev rename and
> nothing else. IMHO it's clean and easy to review if no other changes
> are contained. One reason for this is obviously that I want to use
> cdev for struct cdev not for the class device.

Well, once you add cdev, pdev and dev, you want most uses of dev to
become cdev and some uses to become pdev.

Just bulk renaming dev -> pdev and then bulk renaming pdev -> cdev
seems like lots of churn...

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/