Re: [PATCH] [SCSI] ps3rom: fix error return code

[Geoff Levand]

On Wed, 2014-11-05 at 21:11 +1100, Michael Ellerman wrote:
> From: Julia Lawall <Julia.Lawall@xxxxxxx>
> 
> Set the return variable to an error code as done elsewhere in the function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> ---
>  drivers/scsi/ps3rom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
> index ef23fabe3924..619caf1acc9c 100644
> --- a/drivers/scsi/ps3rom.c
> +++ b/drivers/scsi/ps3rom.c
> @@ -387,6 +387,7 @@ static int ps3rom_probe(struct ps3_system_bus_device *_dev)
>  	if (!host) {
>  		dev_err(&dev->sbd.core, "%s:%u: scsi_host_alloc failed\n",
>  			__func__, __LINE__);
> +		error = -ENOMEM;
>  		goto fail_teardown;
>  	}
>  

Looks OK.  James, please apply.

Acked-By: Geoff Levand <geoff@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/