Re: [PATCH 3/4] PNP: Allow device to override ACPI device sleep

[Peter Hurley]

On 11/05/2014 05:28 PM, Rafael J. Wysocki wrote:
> On Wednesday, November 05, 2014 01:40:53 PM Peter Hurley wrote:
>> If the serial console is an ACPI PNP device, the PNP bus attempts to
>> power-down the device, even though the no_console_suspend command line
>> parameter is specified (eg., debugging suspend/resume).
>>
>> Add PNP_SUSPEND capability which is on by default, but when cleared,
>> prevents pnpacpi_suspend() (which is the ACPI PNP protocol ->suspend()
>> method).
>>
>> Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> 
> While I'm not disagreeing with this entirely, I have a concern.
> 
> There are two types of suspend in Linux these days, runtime suspend and
> system suspend.  What this is about is "device suspend during system
> suspend" only, so the flag name is somewhat confusing.

Yeah, I see your point. I wouldn't want people thinking this had anything
to do with runtime pm.

> Also the flag is only going to be used for consoles, so why don't you
> introduce a PNP_CONSOLE flag and then define pnp_can_suspend() as
> 
> static inline pnp_can_suspend(struct pnp_dev *pnp_dev)
> {
> 	return pnp_dev->protocol->suspend &&
> 		 (!(pnp_dev->capabilities & PNP_CONSOLE) || console_suspend_enabled);
> }

I can do that.

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/