Re: [PATCH 1/2 v2] x86, mce, severity: extend the the mce_severity

[Chen Yucong]

On Wed, 2014-11-05 at 10:27 -0800, Tony Luck wrote:
> > +#define  ONEXCP        .excp = NO_EXCP
> 
I'm sorry, this is a typing error. Thanks!

> Shouldn't this be named "NOEXCP" and used in the initializations
> for the deferred and UCNA table entries?
> 
In fact, "NOEXCP" can be used in the initialization for the deferred
and UCNA table entries. But it may affect the following snippet in
do_machine_check().

     /*
      * When machine check was for corrected/deferred handler don't
      * touch, unless we're panicing.
      */
     if ((severity == MCE_KEEP_SEVERITY ||
          severity == MCE_UCNA_SEVERITY) && !no_way_out)
              continue;

If `no_way_out' equals 1, we may need to dump/decode corrected/deferred 
error information. So if we use "NOEXCP" to initialize the deferred and
UCNA table entries, do_machine_check will skip checking deferred/UCNA
entry when `no_way_out' is set to 1.

thx!
cyc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/