Re: [PATCH 3/3 v3] drivers/bus: Device driver for FSL-MC DPRC devices

From: Alexander Graf
Date: Thu Nov 06 2014 - 08:51:26 EST




On 04.10.14 15:23, J. German Rivera wrote:
> From: "J. German Rivera" <German.Rivera@xxxxxxxxxxxxx>
>
> A DPRC (Data Path Resource Container) is an isolation device
> that contains a set of DPAA networking devices to be
> assigned to an isolation domain (e.g., a virtual machine).
>
> Signed-off-by: J. German Rivera <German.Rivera@xxxxxxxxxxxxx>
> Signed-off-by: Stuart Yoder <stuart.yoder@xxxxxxxxxxxxx>
> ---
> Changes in v3:
> - Addressed comments from Kim Phillips:
> * Renamed files:
> drivers/bus/fsl-mc/fsl_mc_dprc.c -> drivers/bus/fsl-mc/dprc-driver.c
>
> - Addressed comments from Timur Tabi:
> * Changed dprc_scan_container() to just return dprc_scan_objects()
> * Changed all functions that had goto out/error when no common cleanup
> was done, to just have multiple return points.
> * Replaced error cleanup boolean flags with multiple exit points.
> * REmoved __must_chewck from dprc_scan_*() functions
>
> Changes in v2:
> - Addressed comments from Kim Phillips:
> * Fix warning in drivers/bus/fsl-mc/fsl_mc_dprc.c:173
> * Fixed linker errors when MC bus driver built as module
>
> drivers/bus/fsl-mc/Makefile | 3 +-
> drivers/bus/fsl-mc/dprc-driver.c | 383 ++++++++++++++++++++++++++++++++++++++
> drivers/bus/fsl-mc/mc-bus.c | 8 +
> include/linux/fsl/mc-private.h | 10 +
> 4 files changed, 403 insertions(+), 1 deletion(-)
> create mode 100644 drivers/bus/fsl-mc/dprc-driver.c
>
> diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
> index decd339..424e58e 100644
> --- a/drivers/bus/fsl-mc/Makefile
> +++ b/drivers/bus/fsl-mc/Makefile
> @@ -10,5 +10,6 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
> mc-bus-driver-objs := mc-bus.o \
> mc-sys.o \
> dprc.o \
> - dpmng.o
> + dpmng.o \
> + dprc-driver.o
>
> diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
> new file mode 100644
> index 0000000..8be6a2a
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/dprc-driver.c
> @@ -0,0 +1,383 @@
> +/*
> + * Freescale daata path resource container (DPRC) driver

daata? ;)

Is there any way I can play with this bus? How far do I get with only
these 3 patches applied today?


Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/