Re: [PATCH 3/4] macvtap: Use iovec iterators

From: Al Viro
Date: Thu Nov 06 2014 - 12:33:42 EST


On Thu, Nov 06, 2014 at 04:28:20PM +0800, Herbert Xu wrote:

> + if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter))
> return -EFAULT;

Again, wrong calling conventions. It returns how much has it copied.

> + ret = copy_to_iter(&veth, sizeof(veth), iter);
> + if (ret || !iov_iter_count(iter))
> goto done;
Ditto.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/