Re: [PATCH V6 03/18] x86: Use new cache mode type in drivers/video/fbdev/gbefb.c

From: Tomi Valkeinen
Date: Fri Nov 07 2014 - 03:17:26 EST


On 03/11/14 15:01, Juergen Gross wrote:
> Instead of directly using the cache mode bits in the pte switch to
> using the cache mode type.
>
> Based-on-patch-by: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> drivers/video/fbdev/gbefb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
> index 4aa56ba..6d9ef39 100644
> --- a/drivers/video/fbdev/gbefb.c
> +++ b/drivers/video/fbdev/gbefb.c
> @@ -54,7 +54,8 @@ struct gbefb_par {
> #endif
> #endif
> #ifdef CONFIG_X86
> -#define pgprot_fb(_prot) ((_prot) | _PAGE_PCD)
> +#define pgprot_fb(_prot) (((_prot) & ~_PAGE_CACHE_MASK) | \
> + cachemode2protval(_PAGE_CACHE_MODE_UC_MINUS))
> #endif
>
> /*
>

For this and vermilion fb:

Acked-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>

Tomi


Attachment: signature.asc
Description: OpenPGP digital signature