Re: [PATCH v5 3/5] regulator: of: Add regulator desc param to of_get_regulator_init_data()

[Javier Martinez Canillas]

Hello Mark,

On 11/07/2014 04:07 PM, Mark Brown wrote:
> 
> This is using the regulator descriptor before it is initialized which
> doesn't seem ideal...
>

You are right, even if most of them are not used currently, that may
change in the future so is safer to use it after all fields have been
initialized. I'll double check all drivers to be sure that's the case.

> 
> This is just adding the include to get the declaration of regulator_desc
> as far as I can see, add a forward declaration of it instead.
> 

Perfect, I didn't know what you would prefer. I'll change it in the
next version.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/