Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure

From: Peter Ujfalusi
Date: Mon Nov 10 2014 - 07:54:15 EST


On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

>
> Signed-off-by: Anil Kumar <anilk4.v@xxxxxxxxx>
> ---
> :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c
> sound/soc/davinci/davinci-mcasp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> ret = pm_runtime_get_sync(&pdev->dev);
> if (IS_ERR_VALUE(ret)) {
> dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> + pm_runtime_disable(&pdev->dev);
> return ret;
> }
>
>


--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/