Re: [PATCH 2/4] UBIFS: Add xattr support for symlinks

[Artem Bityutskiy]

On Fri, 2014-10-31 at 13:50 -0500, Ben Shelton wrote:
> From: Subodh Nijsure <snijsure@xxxxxxxxxxxx>
> 
> Signed-off-by: Subodh Nijsure <snijsure@xxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Signed-off-by: Ben Shelton <ben.shelton@xxxxxx>
> Acked-by: Terry Wilcox <terry.wilcox@xxxxxx>
> Acked-by: Gratian Crisan <gratian.crisan@xxxxxx>
> ---
>  fs/ubifs/file.c  |  4 ++++
>  fs/ubifs/xattr.c | 17 ++++++++++++-----
>  2 files changed, 16 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
> index b5b593c..4a1d4cf 100644
> --- a/fs/ubifs/file.c
> +++ b/fs/ubifs/file.c
> @@ -1573,6 +1573,10 @@ const struct inode_operations ubifs_symlink_inode_operations = {
>  	.follow_link = ubifs_follow_link,
>  	.setattr     = ubifs_setattr,
>  	.getattr     = ubifs_getattr,
> +	.setxattr    = ubifs_setxattr,
> +	.getxattr    = ubifs_getxattr,
> +	.listxattr   = ubifs_listxattr,
> +	.removexattr = ubifs_removexattr,

Could you please re-test this with any kernel and carefully verify
symlinks. I think this should not work, because in case of symlinks we
already store the link target path in the inode, and with this patch the
target patch will be over-written with the SELinux label. I expect this
to be seen easily on testing - symlink targets should be corrupted.

Artem.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/