Re: [PATCH v6 10/10] tpm: TPM 2.0 sysfs attributes

[Jason Gunthorpe]

On Mon, Nov 10, 2014 at 02:49:54PM +0200, Jarkko Sakkinen wrote:

>  	if (len > le32_to_cpu(cca->cmd_size)) {
> -		dev_err(chip->dev,
> +		dev_err(&chip->dev,

Is this out of sequence in the patch series?

>  
>  	rc = tpm2_do_selftest(chip);
> -	if (rc) {
> -		dev_err(dev, "self-test failed\n");
> +	if (rc)
>  		return rc;
> -	}
>  
>  	rc = tpm_chip_register(chip);
> -	if (rc) {
> -		dev_err(dev, "registering the chip failed\n");
> +	if (rc)
>  		return rc;
> -	}

Ditto.

Also, just:

   return tpm_chip_register(chip);

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/