RE: [PATCH v4] i2c/at91: adopt pinctrl support

[Yang, Wenyou]

Hi,

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@xxxxxxxxxxxxxxxxxx]
> Sent: Monday, November 10, 2014 7:13 PM
> To: Yang, Wenyou; wsa@xxxxxxxxxxxxx; Desroches, Ludovic
> Cc: khilman@xxxxxxxxxx; Ferre, Nicolas; linux-kernel@xxxxxxxxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4] i2c/at91: adopt pinctrl support
> 
> Hello.
> 
> On 11/10/2014 4:55 AM, Wenyou Yang wrote:
> 
> > Amend the at91 i2c pin controller
> 
>     You're amending the hardware itself, really? :-)
> 
> > to optionally take a pin controlhandle
> 
>     I don't see the code that does this.
> 
> > and set the state of the pins to:
> > - "default" on boot and resume.
> 
>     I don't see where you are changing anything for the probe() method.
> Perhaps you meant the driver core code which selects the dafault profile
> automatically?
Yes, the driver core code default do, so remove the redundant code from _probe function.

> 
> > - "sleep" on suspend().
> 
> > This should make it possible to optimize energy usage for the pins
> > both for the suspend/resume cycle
> 
> > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx>
> > ---
> > Hi Wolfram,
> >
> > Thanks a lot.
> >
> > The change of this version is to remove
> > 	pinctrl_pm_select_default_state(&pdev->dev) from the _probe function.
> 
>     Aha, you've specifically removed this...
> 
> WBR, Sergei

Best Regards,
Wenyou Yang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/