Re: [PATCH v3 10/11] perf/x86/intel: Perform rotation on Intel CQM RMIDs

From: Peter Zijlstra
Date: Tue Nov 11 2014 - 04:37:34 EST


On Mon, Nov 10, 2014 at 09:31:40PM +0000, Matt Fleming wrote:
> Actually, yeah, that does look like it'd work. Are you OK with me adding
> an enum to the cqm_rmid_entry? You had concerns in the past about
> growing the size of the struct.

That was because I was thinking you did nr_rmid*sizeof(cqm_rmid_entry)
allocation, shortly thereafter I noticed you did a pointer alloc and
then allocated each individual entry.

Also, that enum can fit the hole you made there I think.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/