Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static

From: David Vrabel
Date: Tue Nov 11 2014 - 05:21:13 EST


On 11/11/14 05:43, Juergen Gross wrote:
> Some functions in arch/x86/xen/p2m.c are used locally only. Make them
> static. Rearrange the functions in p2m.c to avoid forward declarations.
>
> While at it correct some style issues (long lines, use pr_warn()).

Please don't add extra stuff like this. In general if you feel yourself
wring "while at it..." or "also..." then you need another patch.

I also don't care about long lines if they are under 100 characters.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/