Re: [PATCH v4] mmc: add Toshiba PCI SD controller driver

[Ulf Hansson]

On 11 November 2014 12:30, Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tuesday 11 November 2014, Ulf Hansson wrote:
>> On 10 November 2014 17:58, Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
>> > This patch resurrects an old never-finished driver for Toshiba PCI SD
>> > controllers found in some older Toshiba laptops (such as Portege R100):
>> >
>> > 02:0d.0 System peripheral [0880]: Toshiba America Info Systems SD TypA
>> > Controller [1179:0805] (rev 05)
>> >
>> > The code is fixed, cleaned up and successfully tested with SD, SDHC, SDXC
>> > and MMC cards on Portege R100. (MMC cards don't even work in Windows!)
>> > SDIO probably does not work (don't have any SDIO card).
>> >
>> > The hardware is slow (around 2 MB/s - same in Windows) because it does
>> > not support bus mastering (busmaster enable bit cannot be set in PCI
>> > control reg). Also the card clock is limited to 16MHz (33MHz PCI clock
>> > divided by 2).
>> >
>> > Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx>
>>
>> Hi Ondrej,
>>
>> I get these compiler warning while building for x86. Can you please fix
>> them.
>>
>> ../drivers/mmc/host/toshsd.c: In function âtoshsd_initâ:
>> ../drivers/mmc/host/toshsd.c:70:9: warning: large integer implicitly
>> truncated to unsigned type [-Woverflow]
>>          host->ioaddr + SD_INTMASKCARD);
>>          ^
>
> Which GCC version did you use? I get no warnings with 4.7.2 (Debian Stable).

gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/