Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi

[Andy Yan]

On 2014å11æ11æ 22:40, Zubair Lutfullah Kakakhel wrote:
> Hi Andy,
>
> Some minor comments inline.
>
> On 11/11/14 12:54, Andy Yan wrote:
> > Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v7: None
> > Changes in v6: None
> > Changes in v5: None
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2: None
> >
> >   .../devicetree/bindings/drm/bridge/dw-hdmi.txt     | 38 ++++++++++++++++++++++
> >   1 file changed, 38 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
> >
> > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
> > new file mode 100644
> > index 0000000..aa7ed17
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
> > @@ -0,0 +1,38 @@
> > +DesignWare HDMI bridge bindings
> > +
> > +Required properities:
> 	
> 	    ^properties
>
> > +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi"
>       ^compatible
  thanks , these will be fixed next.
> > +	      "rockchip,rk3288-dw-hdmi"
> This will need to come in a separate series which adds rk3288 hdmi support..
 we will add rk3288 hdmi platform code soon
> > +- reg: physical base address of the controller and length
> > +- ddc-i2c-bus: the ddc i2c bus
> > +- interrupts: The interrupt number to the cpu
> > +
> > +Optional properties
> > +- reg-io-width: the width of the reg:1,4, default set to 1 if not present
> > +
> > +Example:
> > +	hdmi: hdmi@0120000 {
> > +		compatible = "fsl,imx6q-hdmi";
> > +		reg = <0x00120000 0x9000>;
> > +		interrupts = <0 115 0x04>;
> > +		gpr = <&gpr>;
> > +		clocks = <&clks 123>, <&clks 124>;
> > +		clock-names = "iahb", "isfr";
> > +		ddc-i2c-bus = <&i2c2>;
> > +
> > +		port@0 {
> > +			reg = <0>;
> > +
> > +			hdmi_mux_0: endpoint {
> > +				remote-endpoint = <&ipu1_di0_hdmi>;
> > +			};
> > +		};
> > +
> > +		port@1 {
> > +			reg = <1>;
> > +
> > +			hdmi_mux_1: endpoint {
> > +				remote-endpoint = <&ipu1_di1_hdmi>;
> > +			};
> > +		};
> > +	};
> Thanks
> ZubairLK
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/