Re: [PATCH 1/2] mfd: dln2: fix _dln2_transfer return code

[Octavian Purdila]

On Tue, Nov 11, 2014 at 6:18 PM, Julia Lawall <julia.lawall@xxxxxxx> wrote:
> On Tue, 11 Nov 2014, Octavian Purdila wrote:
>
>> If wait_for_completion_interruptible_timeout returns a positive value
>> it may be propagated as the return value of _dln2_transfer. This
>> contradicts the documentation of the function and exposes unnecessary
>> internals to the callers.
>>
>> This patch makes sure to set the return value to 0 in that case.
>
> I didn't keep around the code or the address of the git tree, but I wonder
> if this makes a later assignment of ret to 0 unnecessary?
>

Yes, you are right, we can skip setting it when ibuf is NULL. I will
send v2 that fixes this and the coding style issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/