Re: [PATCH v10 2/3] power-domain: rockchip: add power doamin driver

[Kevin Hilman]

Caesar Wang <caesar.wang@xxxxxxxxxxxxxx> writes:

> In order to meet high performance and low power requirements, a power
> management unit is designed or saving power when RK3288 in low power mode.
> The RK3288 PMU is dedicated for managing the power ot the whole chip.
>
> Signed-off-by: Jack Dai <jack.dai@xxxxxxxxxxxxxx>
> Signed-off-by: jinkun.hong <jinkun.hong@xxxxxxxxxxxxxx>
> Signed-off-by: Caesar Wang <caesar.wang@xxxxxxxxxxxxxx>
>
> ---
>
> Changes in v10:
>     - this switches over domain infos to use masks instead of recomputing
>       them each time and also gets rid of custom domain translator and
>       uses standard onecell on.
>
> Changes in v9:
>     - fix v8 changes as follows:
>     - This reconciles the v2 and v7 code so that we power domain have
>       lists of clocks they toggle on and off during power transitions and
>       independently from power domains clocks we attach clocks to devices
>       comprising power domain and prepare them so they are turn on and off
>       by runtime PM.

I still don't like having lists of clocks in the power-domain DT. 

DT is supposed to describe the hardware, and clocks are properties of
devices, not power-domains, so the DT description should follow from that.

I understand that some device may not be probed etc. when a power-domain
needs to transition, but the power-domain driver can still get the list
of clocks it needs from the device nodes within the domain, so it
shouldn't matter whether devices are probed or not.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/