Re: [PATCH v6 00/48] kernel: Add support for power-off handler call chain

From: Pavel Machek
Date: Tue Nov 11 2014 - 13:50:30 EST


On Tue 2014-11-11 10:20:23, Guenter Roeck wrote:
> On Mon, Nov 10, 2014 at 09:33:48AM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > Introduce a system power-off handler call chain to solve the described
> > > problems. This call chain is expected to be executed from the architecture
> > > specific machine_power_off() function. Drivers providing system power-off
> > > functionality are expected to register with this call chain. By using the
> > > priority field in the notifier block, callers can control power-off
> > > handler
> >
> > Linus rather disliked the idea of notifier chains for this... And I
> > don't see how it got addressed.
> >
> Hi all,
>
> After more thought, I concluded that it is technically impossible to support
> multiple power-off handlers without some kind of list or call chain, no matter
> how it is called. Given the opposition from Linus and the power maintainers
> to the series, I decided to shelf it.

Well, you can still do preparations -- current code directly setting
pm_power_off is ugly -- so that if you want to switch to call chain
later, it will be easy.

And if that does not happen, we still get the cleanup :-).

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/