Re: [PATCH] selftests/net: psock_fanout seg faults in sock_fanout_read_ring()

From: David Miller
Date: Tue Nov 11 2014 - 21:44:15 EST


From: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
Date: Tue, 11 Nov 2014 10:04:13 -0700

> The while loop in sock_fanout_read_ring() checks mmap region
> bounds after access, causing it to segfault. Fix it to check
> count before accessing header->tp_status. This problem can be
> reproduced consistently when the test in run as follows:
>
> make -C tools/testing/selftests TARGETS=net run_tests
> or
> make run_tests from tools/testing/selftests
> or
> make run_test from tools/testing/selftests/net
>
> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>

Definitely looks correct to me, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/