Re: [PATCH V2 2/2] PCI: generic: Add msi_parent DT binding

From: Suravee Suthikulpanit
Date: Wed Nov 12 2014 - 06:38:16 EST


On 11/12/14 13:56, Srikanth Thokala wrote:
@@ -122,9 +123,19 @@ static int gen_pci_config_write(struct pci_bus *bus, unsigned int devfn,
> return PCIBIOS_SUCCESSFUL;
> }
>
>+static int gen_pci_set_msi_parent(struct pci_bus *bus)
>+{
>+ struct gen_pci *pci = bus_to_gen_pci(bus);
>+
>+ bus->msi = pci->mchip;
>+
>+ return PCIBIOS_SUCCESSFUL;
>+}
>+
> static struct pci_ops gen_pci_ops = {
> .read = gen_pci_config_read,
> .write = gen_pci_config_write,
>+ .set_msi_parent = gen_pci_set_msi_parent,
We assign the msi chip through add_bus() call, do we still need this?

Certain architecture (i.e arm64) doesn't implement struct hw_pci. Therefore, there is no add_bus(). However, this new API should allow non-arch dependent implementation.

Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/