Re: [PATCH v3 1/2] of: Rename "poweroff-source" property to "system-power-controller"
From: Grant Likely
Date: Wed Nov 12 2014 - 06:46:34 EST
On Tue, Nov 11, 2014 at 7:01 PM, Romain Perier <romain.perier@xxxxxxxxx> wrote:
> 2014-11-11 16:01 GMT+01:00 Grant Likely <grant.likely@xxxxxxxxxx>:
>> So, to be a little pendantic, the 'ti,' prefix is basically just for
>> backwards compatibility with the old binding, and that old binding is
>> only used on palmas.c, tps65*.c and twl4030-power.c, correct?
>
> No, the backward compatibility here is only useful for drivers which
> used "ti,system-power-controller" in the past and recently switched to
> the new property through the standard helper function. As most of the
> dts were not updated to use the new property, previous patches broke
> compatibility with "ti,system-power-controller" (this compat would be
> reverted with this serie). Only one driver has this problem, it is
> tps65910.
>
> So, What you propose is that I should handle the old property directly
> from tps65910, and keep the standard helper generic right ?
yes as it is a quirk for only that driver.
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/