Re: [PATCH V3 2/6] sched: idle: cpuidle: Check the latency req before idle

[Daniel Lezcano]

On 11/11/2014 11:20 AM, Peter Zijlstra wrote:
> On Mon, Nov 10, 2014 at 11:21:19PM +0100, Daniel Lezcano wrote:
> > On 11/10/2014 08:48 PM, Peter Zijlstra wrote:
> > > On Mon, Nov 10, 2014 at 06:19:02PM +0100, Daniel Lezcano wrote:
> > > > > I really don't get why the governors should know about this though, its
> > > > > just another state, they should iterate all states and pick the best,
> > > > > given the power usage this state should really never be eligible unless
> > > > > we're QoS forced or whatnot.
> > > >
> > > > The governors just don't use the poll state at all, except for a couple of
> > > > cases in menu.c defined above in the previous email. What is the rational of
> > > > adding a state in the cpuidle driver and do everything we can to avoid using
> > > > it ? From my POV, the poll state is a special state, we should remove from
> > > > the driver's idle states like the arch_cpu_idle() is a specific idle state
> > > > only used in idle.c (but which may overlap with an idle state in different
> > > > archs eg. cpu_do_idle() and the 0th idle state).
> > >
> > > So I disagree, I think poll-idle is an idle mode just like all the
> > > others. It should be an available state to the governor and it should
> > > treat it like any other.
> >
> > The governors are just ignoring it, except for a small timer optimization in
> > menu.c (and I am still not convinced it is worth to have it). I don't see
> > the point to add a state we don't want to use.
>
> The ignoring it is _wrong_. Make that go away and you'll get rid of most
> of the STATE_START crap.
>
> The governors are the place where we combine the QoS constraints with
> idle predictors and pick an idle state, polling is a valid state to
> pick, and given QoS constraints it might be the only state to pick.

Well, I understand your point of view but I still disagree. IMO, the 
poll loop shouldn't be considered as a valid idle state for different 
reasons:

0. thermal issue if wrongly selected from any of the governor

1. a polling loop does not have a valid time measurements even if the 
TIME_VALID flag has been added

2. entering the idle governors is not free, especially the menu 
governor, which is contradictory with zero latency req

3. what is the meaning of having a zero latency (target + exit) idle 
state ? We know it will always succeed if the other fails

4. IIUC, you are suggesting to add the poll loop for all the cpuidle 
drivers. This is a *lot* of changes, I am not afraid about the work to 
do but there is a significant code impact and the entire behavior of the 
cpuidle framework for all the arch will be changed.

So given the points above, why not have one poll function, generic, and 
if we fail to find an idle state or if the req is zero, then fallback to 
the poll loop ?


> > Eg. on my server it was called 2 times over 1313856 times.
> >
> > > I don't tihnk the whole ARCH_HAS_CPU_RELAX thing makes any kind of
> > > sense, _every_ arch has some definition of it, the generic polling loop
> > > is always a valid idle implementation.
> > >
> > > What we can do is always populate the idle state table with it before
> > > calling the regular drivers.
> >
> > I am not sure to understand. You want to add the poll idle loop in all the
> > drivers ?
> >
> > What about "safe_halt()" ? (arch_cpu_idle() for x86). It is also an idle
> > state. Why not add it in the idle state table also ?
>
> Because the latter is actually arch specific, whereas the idle polling
> thing is not.
> You can _always_ poll idle, its generic, its valid, and
> its guaranteed the most responsive method.

I agree with this point but this kind of loop is hardware optimized for 
x86. On the other arch, where today this loop is never used, if we 
change the behavior of the cpuidle framework and introduces this loop, 
it may be selected and stay on this state for a long time (resulting 
from a bad prediction), I am afraid that can lead to some thermal issues.

> The arch drivers get to add arch specific idle states; if a x86 cpuidle
> driver wants to add hlt they can.




--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/