Re: [PATCH v2 4/5] x86/mce: Simplify flow when handling recoverable memory errors

[Borislav Petkov]

On Wed, Nov 12, 2014 at 06:20:58PM +0100, Oleg Nesterov wrote:
> Sorry, I am a bit confused...
> 
> On 11/11, Borislav Petkov wrote:
> >
> > Roughly speaking, we want to be able to mark a task with the sign of
> > death and to kill it, if needed.
> 
> "it" is current, yes?

Yes.

> So I agree with Andy, task_work_add() can work and you can also pass
> paddr/restartable to the handler.

Yes, and it is much simpler than changing the entry.S glue to switch to
the kernel stack for our purposes.

> But,
> 
> > The important part is *before* it
> > gets to run again.
> 
> But it is already running? Perhaps you meant "before it returns to
> user-mode" ?

Right, it runs, while it does so, it triggers an MCE because it touches
some corrupted memory, we jump to the #MC handler and before we return
to user space, we kill that process.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/