Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()
From: SF Markus Elfring
Date: Wed Nov 12 2014 - 16:51:06 EST
>> + goto cleanup1;
>
> 1) Don't use GW-BASIC label names. Label names should reflect what the
> label does such as free_fuse_word or free_fuse_tabel.
>
> 2) Don't use do-nothing labels. Just return directly.
Does the document "CodingStyle" need any extensions for special cases?
Are there any update candidates in the chapter "7: Centralized exiting of functions"?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/