Re: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position

[Minchan Kim]

On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
> In struct zram_table_entry, the element *value* contains obj size and
> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
> instead of (ZRAM_FLAG_SHIFT + 1).
> 
> This patch fixes this issue.
> 
> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
> 
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@xxxxxxxxx>
Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

To be clear about "fixes this issue", it's not a bug but just clean up
so it doesn't change any behavior.

Thanks!

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/