Re: [PATCH v4 05/13] of: Document timings subnode of nvidia,tegra-mc

[Tomeu Vizoso]

On 12 November 2014 15:22, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> On Wed, Nov 12, 2014 at 08:56:28AM +0100, Tomeu Vizoso wrote:
> [...]
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra-mc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra-mc.txt
> [...]
>> +Example board file:
>> +
>> +/ {
>> +     memory-controller@0,70019000 {
>> +             emc-timings-3 {
>> +                     nvidia,ram-code = <3>;
>
> I guess the alternative would be to keep the old names and simply use
> the reg property instead of nvidia,ram-code to be compliant with best
> practices in DT:
>
>                 emc-timings@3 {
>                         reg = <3>;
>
>> +
>> +                     timing-12750000 {
>> +                             clock-frequency = <12750000>;
>
> And:
>
>                         timing@12750000 {
>                                 reg = <12750000>;
>
> But I haven't been following this series too closely so far, so maybe
> that had already been rejected.

It has been mentioned already, but I think nobody has shown any strong
opinions on it. I personally like how it is now as it matches how it's
already done for display-timings.

Regards,

Tomeu

> Thierry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/