Re: [Xen-devel] [PATCH 3/3] x86/xen: use the maximum MFN to calculate the required DMA mask

[Andrew Cooper]

On 12/11/14 15:55, Jan Beulich wrote:
>>>> On 12.11.14 at 16:25, <david.vrabel@xxxxxxxxxx> wrote:
>> +u64
>> +xen_swiotlb_get_required_mask(struct device *dev)
>> +{
>> +	u64 max_mfn;
>> +
>> +	max_mfn = HYPERVISOR_memory_op(XENMEM_maximum_ram_page, NULL);
>> +
>> +	return DMA_BIT_MASK(fls64(max_mfn << PAGE_SHIFT) + 1);
>> +}
> The value the hypercall returns is exclusive and an unsigned long.

All hypercalls return long, despite lack of clarity, or in some cases,
documentation to the contrary.

Almost all hypercalls need the ability to return errors in the form of
negative numbers, and those which don't should not be treated any
differently.  Furthermore, the overflow conditions for the compat
version of XENMEM_maximum_ram_page specifically truncate to INT_MAX and
INT_MIN as boundaries, making the return value signed.

~Andrew

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/