Re: [PATCH] fuse: don't check for file->private_data on open().

[Greg Kroah-Hartman]

On Thu, Nov 13, 2014 at 12:13:32PM +0100, Martin Kepplinger wrote:
> Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi <miklos@xxxxxxxxxx>:
> >On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger <martink@xxxxxxxxx>
> >wrote:
> >
> >> In this week's -next this should have changed. My SSD broke down so i
> >have to delay further work for a few days, i'm sorry.
> >
> >Please be more careful with such patches.  Have you audited all of the
> >(ca. 200) misc drivers?  If not, this might be a good time to do so.
> >If it turns out to be too much, then consider not doing the change.
> >The gain might not be worth the cost.
> >
> >NACK in this form.
> >
> >Thanks,
> >Miklos
> 
> Definitely should have been more careful as I checked fs too late now. I totally unnecessarily broke -next.
> 
> But If fuse-devel is ok with a fix like the one i sent (still has to get tested too) i believe we're covered. I still call for independent review though.

I don't think it's worth it anymore, I'm going to revert the original
patch that caused these problems, as it has the potential to break other
drivers in ways that are not obvious (i.e. not at build time.)

Sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/