Re: randconfig build error with next-20141113, in fs/pstore/inode.c

From: Kees Cook
Date: Thu Nov 13 2014 - 14:21:24 EST


On Thu, Nov 13, 2014 at 11:18 AM, Luck, Tony <tony.luck@xxxxxxxxx> wrote:
>> Building with the attached random configuration file,
>>
>> fs/built-in.o: In function `pstore_check_syslog_permissions':
>> inode.c:(.text+0x13a1bd): undefined reference to `check_syslog_permissions'
>> make: *** [vmlinux] Error 1
>
> Sebastian,
>
> This looks to come from your "Honor dmesg_restrict sysctl on dmesg dumps" patch
>
> The randconfig doesn't have CONFIG_PRINTK. I guess we need to provide a stub
> in <linux/syslog.h> to cover this.

Without CONFIG_PRINTK, check_syslog_permissions should probably fail.

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/