Re: [PATCH] mm: mincore: add hwpoison page handle

[Naoya Horiguchi]

On Wed, Nov 12, 2014 at 09:20:22AM -0500, Johannes Weiner wrote:
> On Wed, Nov 12, 2014 at 11:39:29AM +0800, Weijie Yang wrote:
> > When encounter pte is a swap entry, the current code handles two cases:
> > migration and normal swapentry, but we have a third case: hwpoison page.
> > 
> > This patch adds hwpoison page handle, consider hwpoison page incore as
> > same as migration.
> > 
> > Signed-off-by: Weijie Yang <weijie.yang@xxxxxxxxxxx>

Acked-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>

> 
> The change makes sense:
> 
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> 
> But please add a description of what happens when a poison entry is
> encountered with the current code.  I'm guessing swap_address_space()
> will return garbage and this might crash the kernel?

Yes, I think that's correct.

Thanks,
Naoya Horiguchi--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/