Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

[Andy Yan]

On 2014å11æ14æ 18:23, Zubair Lutfullah Kakakhel wrote:
> Hi Andy
>
> On 14/11/14 03:31, Andy Yan wrote:
> > Rockchip RK3288 hdmi is compatible with dw_hdmi
> >
> > Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> >
> > ---
> >
> > Changes in v10:
> > - add more display mode support mpll configuration for rk3288
> >
> > Changes in v9:
> > - move some phy configuration to platform driver
> >
> > Changes in v8: None
> > Changes in v7: None
> > Changes in v6: None
> > Changes in v5: None
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2: None
> >
> >   drivers/gpu/drm/bridge/dw_hdmi.c            |  10 +
> >   drivers/gpu/drm/bridge/dw_hdmi.h            |   3 +-
> >   drivers/gpu/drm/rockchip/Kconfig            |  10 +
> >   drivers/gpu/drm/rockchip/Makefile           |   2 +-
> >   drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++++++++++++++++++++
> >   include/drm/bridge/dw_hdmi.h                |   1 +
> >   6 files changed, 379 insertions(+), 2 deletions(-)
> >   create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> >
> > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> > index a2876fe..1dd1f0b 100644
> > --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> > @@ -715,6 +715,13 @@ static void dw_hdmi_phy_enable_tmds(struct dw_hdmi *hdmi, u8 enable)
> >   			 HDMI_PHY_CONF0_ENTMDS_MASK);
> >   }
> >   
> > +static void dw_hdmi_phy_enable_spare(struct dw_hdmi *hdmi, u8 enable)
> > +{
> > +	hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
> > +			 HDMI_PHY_CONF0_SPARECTRL_OFFSET,
> > +			 HDMI_PHY_CONF0_SPARECTRL_MASK);
> > +}
> > +
> What does enable spare do? Can other future SoCs use it?
>
> This looks like DW specific. And can be a separate commit that adds a feature to the dw hdmi driver.
  Actually I am not very clearly about this bit, but RK3288 HDMI will 
not work without this bit enable.
  On imx6, the description about this bit is:Reserved. Spare pin control.
  On rk3288, the description is: svsret/sparectrl
   Both are very simple.
> Thanks
> ZubairLK
>
> >   static void dw_hdmi_phy_gen2_pddq(struct dw_hdmi *hdmi, u8 enable)
> >   {
> >   	hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
> > @@ -846,6 +853,9 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep,
> >   	dw_hdmi_phy_gen2_txpwron(hdmi, 1);
> >   	dw_hdmi_phy_gen2_pddq(hdmi, 0);
> >   
> > +	if (hdmi->dev_type == RK3288_HDMI)
> > +		dw_hdmi_phy_enable_spare(hdmi, 1);
> > +
> >   	/*Wait for PHY PLL lock */
> >   	msec = 5;
> >   	do {
> > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.h b/drivers/gpu/drm/bridge/dw_hdmi.h
> > index b8412a9..30a6b28 100644
> > --- a/drivers/gpu/drm/bridge/dw_hdmi.h
> > +++ b/drivers/gpu/drm/bridge/dw_hdmi.h
> > @@ -837,7 +837,8 @@ enum {
> >   	HDMI_PHY_CONF0_PDZ_OFFSET = 7,
> >   	HDMI_PHY_CONF0_ENTMDS_MASK = 0x40,
> >   	HDMI_PHY_CONF0_ENTMDS_OFFSET = 6,
> > -	HDMI_PHY_CONF0_SPARECTRL = 0x20,
> > +	HDMI_PHY_CONF0_SPARECTRL_MASK = 0x20,
> > +	HDMI_PHY_CONF0_SPARECTRL_OFFSET = 5,
> Cheers,
> ZubairLK
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/