Re: [PATCH V2 1/7] arm64: dts: Add APM X-Gene USB DTS node

[Arnd Bergmann]

On Thursday 13 November 2014 16:19:55 Feng Kan wrote:
> 
> +               usb0: dwusb@19000000 {
> +                       status = "disabled";
> +                       compatible = "xhci-platform";
> +                       reg =  <0x0 0x19000000 0x0 0x100000>;
> +                       interrupts = <0x0 0x89 0x4>;
> +                       dma-coherent;
> +               };
> +
> +               usb1: dwusb@19800000 {
> +                       status = "disabled";
> +                       compatible = "xhci-platform";
> +                       reg =  <0x0 0x19800000 0x0 0x100000>;
> +                       interrupts = <0x0 0x8a 0x4>;
> +                       dma-coherent;
> +               };
> 

Call the nodes 'usb', not 'dwusb'. Should these be 'status="disabled"', or
do you expect every machine to have both connected?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/