Re: [RFC][PATCH 10/23 v4] tracing/uprobes: Do not use return values of trace_seq_printf()

[Steven Rostedt]

On Fri, 14 Nov 2014 10:37:33 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Sat, 15 Nov 2014 00:35:15 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
>  
> > >  	for (i = 0; i < tu->tp.nr_args; i++) {
> > >  		struct probe_arg *parg = &tu->tp.args[i];
> > >  
> > > -		if (!parg->type->print(s, parg->name, data + parg->offset, entry))
> > > -			goto partial;
> > > +		parg->type->print(s, parg->name, data + parg->offset, entry);
> > 
> > In 7/23 you've left loop canceling path, why don't you do same thing here?
> 
> While rebasing this series on my latest code, this patch conflicted. I
> notice the difference too (just two minutes ago!).
> 
> I agree, it should break out still.
> 
> Srikar, can I still have your Reviewed-by if I do that?
> 

Here's the new patch:

-- Steve