Re: [RFC][PATCH 17/23 v4] tracing: Have seq_buf use full buffer
From: Steven Rostedt
Date: Fri Nov 14 2014 - 15:56:36 EST
On Fri, 14 Nov 2014 12:30:01 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > Hmm, we should not apply this patch before we fix all other locations
> > accessing seq.len. We need to make sure that they do not access
> > outside of the buffer when seq.len = seq.size + 1.
> >
> > See my comments for "[RFC][PATCH 13/23 v4] tracing: Create seq_buf
> > layer in trace_seq"
>
> I agree. As I replied there, I'll add a patch before this gets applied
> (right after seq_buf_left() is introduced), that will fix those issues.
I made the move of seq_buf_used() before the full buffer usage patch,
and here's a patch I added.
I'll be posting a v5 with all these changes too, but this may make it
easier to review:
-- Steve