Re: [PATCH 1/6] usb: chipidea: add a core function to setup ci_hdrc_platform_data

[Peter Chen]

On Fri, Nov 14, 2014 at 04:34:55PM +0100, Antoine Tenart wrote:
> Peter,
> 
> On Fri, Nov 14, 2014 at 09:16:55AM +0800, Peter Chen wrote:
> > 
> > Ok, Antoine, I find this patch set may not have many benefits due to
> > below reasons:
> > - There is already function ci_get_platdata to do the similar things
> > - If the PHY can't get from the DT, it will use devm_phy_get or
> > devm_usb_get_phy to get, this code has already in core.
> > 
> > I am apologized that I wanted you to do a patch for moving get PHY
> > operation to core, it doesn't have many benefits currently
> > - For non-dt user, the phy get function has already in core like I said
> > above.
> > - For dt generic phy user, it uses of_phy_get, the second parameter
> > con_id may be different for platforms.
> > - For dt usb phy, it uses devm_usb_get_phy_by_phandle, the second
> > parameters phandle may be different for platforms.
> 
> Ok.
> 
> > So, please rebase my next tree which your generic phy patch set has
> > already in, and send your generic usb2 chipidea patch base on it.
> 
> I just rebased my usb2 ci generic driver series and sent it to you and
> to the mailing lists. Since there is not reason from now to delay it, I
> expect it to be merged soon. I wouldn't want to miss yet another release.
> 
> Thanks,
> 

I hope soon, just your generic phy patch set changed lots of things, and
spent too much time on reviewing.

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/