Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

[Lee Jones]

On Thu, 13 Nov 2014, Charles Keepax wrote:

> On Thu, Nov 13, 2014 at 10:12:28AM +0000, Lee Jones wrote:
> > On Tue, 11 Nov 2014, Richard Fitzgerald wrote:
> > 
> > > Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/mfd/Kconfig              |    6 +
> > >  drivers/mfd/Makefile             |    3 +
> > >  drivers/mfd/arizona-core.c       |   91 ++-
> > >  drivers/mfd/arizona-irq.c        |   42 +-
> > >  drivers/mfd/arizona-spi.c        |    9 +
> > >  drivers/mfd/arizona.h            |    5 +
> > >  drivers/mfd/cs47l24-tables.c     | 1632 ++++++++++++++++++++++++++++++++++++++
> > 
> > No chance.
> > 
> > Please resend with these in a header file (like all of the others).
> > 
> > I'd also like Charles' Reviewed-by before accepting.
> 
> This looks good to me. I don't quite follow what you are
> requesting with the header file? This still uses the header file
> for the registers but just defining which are available on this
> chip.

Looks like I was a little hasty with my comments.  However 8000 lines
over 4 platforms just to describe which registers are readable is all
a little bit grim.  Is there any way you can use ranges instead of
listing every single register on the chip?  How many gaps are there? 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/