Re: [PATCH 20/26 v5] seq_buf: Add seq_buf_can_fit() helper function

From: Steven Rostedt
Date: Mon Nov 17 2014 - 19:57:01 EST


On Mon, 17 Nov 2014 16:35:32 -0800
Joe Perches <joe@xxxxxxxxxxx> wrote:


> What "logic" does it place in one place and
> how does it matter?

Look at the next patch.

>
> I don't see it making mistakes more or less
> likely, I just see it being used to avoid
> setting the overflow state which seems like
> more of an error than anything else.
>
> Why avoid setting overflow at all?
>

It has nothing to do with overflow. Where did you get that from?

It has to do with updating the seq->len value or not.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/