Re: [PATCH 20/26 v5] seq_buf: Add seq_buf_can_fit() helper function

[Joe Perches]

On Mon, 2014-11-17 at 21:37 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2014 17:48:37 -0800
> Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
> > > On Mon, 17 Nov 2014 17:07:58 -0800
> > > Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > > > Look at the next patch.
> > > > I don't have it and you are not cc'ing me.
> > > It's on LKML.
> > 
> > And?  There's no convenient way to retrieve it.
> 
> You're not subscribed?

I am subscribed and I delete stuff, don't you?

> > > Um, that may be the case for seq_file, but it is not the case for
> > > trace_seq. seq_buf is influenced by seq_file because I have a patch to
> > > make seq_file use it, but it's also the guts of trace_seq that has some
> > > different requirements. And it's also not the case with the users of
> > > seq_buf in the last patch.
> > 
> > I think your patch subject description needs expanding.
> > It says seq_buf, nothing about trace.
> 
> It doesn't need to. This helps out the code. seq_buf has nothing to do
> with seq_file (yet).

No, I don't think it does help seq_buf.  It only helps trace.

btw:

I think you should cc Al Viro on the entire patch set.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/