Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

[Lee Jones]

On Mon, 17 Nov 2014, Mark Brown wrote:

> On Mon, Nov 17, 2014 at 12:54:33PM +0000, Richard Fitzgerald wrote:
> > On Mon, Nov 17, 2014 at 12:16:48PM +0000, Lee Jones wrote:
> 
> > > Looks like I was a little hasty with my comments.  However 8000 lines
> > > over 4 platforms just to describe which registers are readable is all
> > > a little bit grim.  Is there any way you can use ranges instead of
> > > listing every single register on the chip?  How many gaps are there? 
> 
> > It's debatable. Ranges would be possible but there are a lot of gaps.
> > Personally, speaking as someone who has to maintain these drivers, I
> > like that fact that I can look at this file and see exactly which registers
> > are readable and volatile because they are all explicitly listed. It's also
> > useful that the files are searchable for specific registers.
> 
> > I'll point Charles at this to get his opinion.
> 
> It's probably also worth pointing out that while ranges do compress the
> data a bit they make it harder to answer questions like "is this
> register mapped properly" since the question becomes "is the numeric
> value of this symbol between the numeric values of any of these other
> pairs of symbols we have listed here".  I generally find it harder to
> review drivers using ranges since when checking that things are mapped
> voatile or whatever you have to do lookups like that.

Very well, thanks Mark and Charles.

How about we go back to my original idea then and chucking all of
these massive tables into a nice header file in include?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/