Re: [PATCH] arm64/mm: Remove hack in mmap randomize layout

[Will Deacon]

On Mon, Nov 17, 2014 at 11:02:19PM +0000, Yann Droneaud wrote:
> Since commit 8a0a9bd4db63 ('random: make get_random_int() more
> random'), get_random_int() returns a random value for each call,
> so comment and hack introduced in mmap_rnd() as part of commit
> 1d18c47c735e ('arm64: MMU fault handling and page table management')
> are incorrects.
> 
> Commit 1d18c47c735e seems to use the same hack introduced by
> commit a5adc91a4b44 ('powerpc: Ensure random space between stack
> and mmaps'), latter copied in commit 5a0efea09f42 ('sparc64: Sharpen
> address space randomization calculations.').
> 
> But both architectures were cleaned up as part of commit
> fa8cbaaf5a68 ('powerpc+sparc64/mm: Remove hack in mmap randomize
> layout') as hack is no more needed since commit 8a0a9bd4db63.
> 
> So the present patch removes the comment and the hack around
> get_random_int() on AArch64's mmap_rnd().
> 
> Cc: Dan McGee <dpmcgee@xxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Anton Blanchard <anton@xxxxxxxxx>
> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Fixes: 1d18c47c735e ('arm64: MMU fault handling and page table management')
> Signed-off-by: Yann Droneaud <ydroneaud@xxxxxxxxxx>
> ---
>  arch/arm64/mm/mmap.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

Thanks, this looks sensible:

  Acked-by: Will Deacon <will.deacon@xxxxxxx>

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/