Re: [PATCH] of/address: Don't throw errors on absent ranges properties

[Grant Likely]

On Fri, 14 Nov 2014 17:58:23 +1100
, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
 wrote:
> The core always tries to translate any "reg" property to construct the platform
> device names. This results in a pile of "OF: no ranges; cannot translate" errors
> in dmesg whenever we expose things like i2c devices that cannot directly translate
> to the MMIO space.

I don't have a problem with the change, but it seems to be catching an
odd usage of of_device_make_bus_id(). Why is of_device_make_bus_id()
being called on i2c devices? Those shouldn't be modelled as
platform_devices.

g.

> 
> Turn this into a pr_debug instead
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> 
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index f0541fd..bf1f79d 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -444,7 +444,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
>  	 */
>  	ranges = of_get_property(parent, rprop, &rlen);
>  	if (ranges == NULL && !of_empty_ranges_quirk()) {
> -		pr_err("OF: no ranges; cannot translate\n");
> +		pr_debug("OF: no ranges; cannot translate\n");
>  		return 1;
>  	}
>  	if (ranges == NULL || rlen == 0) {
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/