Re: [PATCH 7/9] staging: panel: Refactor LCD init code

From: Willy Tarreau
Date: Tue Nov 18 2014 - 16:23:36 EST

On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote:
> Rework lcd_init method to make it a little bit more clear about
> the precedence of the params, move LCD geometry and pins layout
> to the LCD struct and thus make the LCD-related module params
> effectively read-only.
> Signed-off-by: Mariusz Gorski <marius.gorski@xxxxxxxxx>

Acked-by: Willy Tarreau <w@xxxxxx>

I like this refactoring. However I don't know if you got your LCD module
to work or not, but for such important changes you should definitely test
the code, since it's very easy to introduce minor bugs or even to fix a
bug that used to make the whole driver work...


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at